X-Git-Url: http://git.veekun.com/zzz-floof.git/blobdiff_plain/55270a42bf0699bd78b95a945fddd73a165507ee..40a5c182712d31d44aeacddd16a457f5ab707de7:/floof/controllers/art.py diff --git a/floof/controllers/art.py b/floof/controllers/art.py index 7378f7a..be75ee7 100644 --- a/floof/controllers/art.py +++ b/floof/controllers/art.py @@ -1,46 +1,126 @@ import logging -from pylons import request, response, session, tmpl_context as c -from pylons.controllers.util import abort, redirect_to - +from pylons import request, response, session, tmpl_context as c, h +from pylons.controllers.util import abort, redirect +from pylons import url from floof.lib.base import BaseController, render log = logging.getLogger(__name__) import elixir -from floof.model.art import Art +from floof.model.users import User +from floof.model import Art, Rating, UserRelation +from floof.model.comments import Discussion -class ArtController(BaseController): +from sqlalchemy.exceptions import IntegrityError + +from wtforms.validators import ValidationError +from wtforms import * - # def index(): - # c.artwork = Art.query.order_by(Art.id.desc()).all() - # return render + +class ArtUploadForm(Form): + by = TextField('Artists') + file = FileField('Upload') + url = TextField('Link') + + # TODO: make this general purpose + def validate_file(self, field): + if field.data == u'': + raise ValidationError('File is required') + + # Also make this into a general User List field validator + """ PLEASE NOTE! I just realized that I need to have a __str__ method on User + to get it to write the usernames back in the form when it redisplays them, since + this validator turns them into user objects instead. This fact actually sounds dangerous + to me in the future, since it means I proably shouldn't be changing the data input + by the user right here in the validator, or the user will see the post-mangled data instead + of what they actually typed. Hm. + + One solution to this could be to only look up the users after normal validation is over, + and then manually add validation errors to the form if that fails. But I think that kind of + sucks. Perhaps the ideology in Formish, where they keep Validation and Conversion as + separate tasks, is a better way of doing it? That way there is less risk of changing the user's + input -- you do that at the conversiot stage -- yet it is still encapsulated in the form workflow. + Hm. But that means I'd have to query for the users in the validation step and throw them away, + or something equally stupid. Guess there's no perfect solution here, but I thought it was + worth discussing. + + Btw, this is meant to be used by a field with multi user autocompletion on it (like on stackoverflow tags), + so the user should never actually submit anything invalid unless they disable javascript and force it. + """ + def validate_by(self, field): + if not field.data: + raise ValidationError("Needs at least one creator") + user_names = field.data.split() + users = [] + # TODO: Could totally do a filter__in here instead of picking them out individually + for user_name in user_names: + user = User.get_by(name=user_name) + if not user: + raise ValidationError("Couldn't find user %s" % user_name) + users.append(user) + field.data = users + +class ArtController(BaseController): + def __before__(self, id=None): + super(ArtController, self).__before__() + # Awesome refactoring! + if id: + c.art = h.get_object_or_404(Art, id=id) def new(self): """ New Art! """ + c.form = ArtUploadForm() return render("/art/new.mako") + # TODO: login required + def create(self): + c.form = ArtUploadForm(request.params) + if c.form.validate(): + + c.art = Art(uploader=c.user, **request.params) + c.art.discussion = Discussion(count=0) + + for artist in c.form.by.data: + UserRelation(user=artist, kind="by", creator=c.user, art=c.art) + + file = request.params['file'] + + try: + elixir.session.commit() + redirect(url('show_art', id=c.art.id)) + except IntegrityError: + # hurr, there must be a better way to do this but I am lazy right now + hash = c.art.hash + elixir.session.rollback() + duplicate_art = Art.get_by(hash=hash) + h.flash("We already have that one.") + redirect(url('show_art', id=duplicate_art.id)) + + else: + ## TODO: JavaScript should be added to the upload form so that it is + ## impossible to submit the form when it contains any invalid users, + ## so this never happens. Only autocompled usernames should be allowed. + return render("/art/new.mako") - def upload(self): - print "PARAMS", request.params - Art(uploaded_by=c.user, **request.params) - elixir.session.commit() - redirect_to(controller="main", action="index") def show(self, id): - c.art = Art.get(id) - c.your_score = c.art.user_score(c.user) + # c.art = h.get_object_or_404(Art, id=id) + if c.user: + c.your_score = c.art.user_score(c.user) return render("/art/show.mako") - - # should force logged in on these things - def tag(self, id): - art = Art.get(id) - art.add_tags(request.params["tags"], c.user) - elixir.session.commit() - redirect_to(action="show", id=art.id) - + + + # TODO: login required def rate(self, id): - art = Art.get(id) - art.rate(request.params["score"], c.user) + # c.art = h.get_object_or_404(Art, id=id) + score = request.params.get("score") + if score and score.isnumeric(): + score = int(score) + else: + score = Rating.reverse_options.get(score) + + c.art.rate(score, c.user) elixir.session.commit() - redirect_to(action="show", id=art.id) + + redirect(url('show_art', id=c.art.id))