From: Petr Viktorin <encukou@gmail.com>
Date: Tue, 29 Mar 2011 20:50:23 +0000 (+0300)
Subject: Update the comment for the Postgres version of pokedex load.
X-Git-Tag: veekun-promotions/2011041101~17^2~6
X-Git-Url: http://git.veekun.com/zzz-pokedex.git/commitdiff_plain/bc9819d9b116f80d391c702d33d9d873d25d92b0?ds=sidebyside;hp=cdf8761bc6f07dfd039e278f9c6d7c2c86c7b50f

Update the comment for the Postgres version of pokedex load.
---

diff --git a/pokedex/db/load.py b/pokedex/db/load.py
index a6e9d4a..b57d935 100644
--- a/pokedex/db/load.py
+++ b/pokedex/db/load.py
@@ -174,14 +174,10 @@ def load(session, tables=[], directory=None, drop_tables=False, verbose=False, s
 
         if not safe and session.connection().dialect.name == 'postgresql':
             """
-            Postgres' CSV dialect is nearly the same as ours, except that it
-            treats completely empty values as NULL, and empty quoted
-            strings ("") as an empty strings.
-            Pokedex dump does not quote empty strings. So, both empty strings
-            and NULLs are read in as NULL.
-            For an empty string in a NOT NULL column, the load will fail, and
-            load will fall back to the cross-backend row-by-row loading. And in
-            nullable columns, we already load empty stings as NULL.
+            Postgres' CSV dialect works with our data, if we mark the not-null
+            columns with FORCE NOT NULL.
+            COPY is only allowed for DB superusers. If you're not one, use safe
+            loading (pokedex load -S).
             """
             session.commit()
             not_null_cols = [c for c in column_names if not table_obj.c[c].nullable]