X-Git-Url: http://git.veekun.com/zzz-spline-frontpage.git/blobdiff_plain/4bb3ad19bae18a454509588df79c8b1470727a18..refs/tags/veekun-promotions/2010091901:/splinext/frontpage/sources.py diff --git a/splinext/frontpage/sources.py b/splinext/frontpage/sources.py index 43d8db8..9b70d4b 100644 --- a/splinext/frontpage/sources.py +++ b/splinext/frontpage/sources.py @@ -4,6 +4,7 @@ implementations. from collections import namedtuple import datetime +import re import subprocess from subprocess import PIPE from urllib2 import URLError @@ -55,7 +56,7 @@ class Source(object): The template will be passed one parameter: the update object, ``update``. """ - def __init__(self, title, icon, link, limit=None, max_age=None): + def __init__(self, config, title, icon, link, limit=None, max_age=None): self.title = title self.icon = icon self.link = link @@ -120,13 +121,8 @@ class CachedSource(Source): # Too early! return - try: - updates = self._poll(self.limit, self.max_age) - cache.get_cache('spline-frontpage')[self.cache_key()] = updates - except Exception: - # Hmm, polling broke. Be conservative and don't do anything; old - # data is probably still OK for now - pass + updates = self._poll(self.limit, self.max_age) + cache.get_cache('spline-frontpage')[self.cache_key()] = updates return @@ -197,6 +193,11 @@ class FeedSource(CachedSource): # If there be a summary, cheerfully trust that it's actually a # summary content = entry.summary + elif 'content' in entry and \ + len(entry.content[0].value) <= self.SUMMARY_LENGTH: + + # Full content is short; use as-is! + content = entry.entry.content[0].value elif 'content' in entry: # Full content is way too much, especially for my giant blog posts. # Cut this down to some arbitrary number of characters, then feed @@ -265,13 +266,20 @@ class GitSource(CachedSource): Base URL to a gitweb installation, so commit ids can be linked to the commit proper. + ``bug_tracker`` + URL to a bug tracker; anything matching "#xxx" will be converted into a + link to this. Should contain a "{0}", which will be replaced by the + bug number. + ``tag_pattern`` Optional. A shell glob pattern used to filter the tags. """ template = '/front_page/git.mako' - def __init__(self, repo_paths, repo_names, gitweb, tag_pattern=None, **kwargs): + def __init__(self, repo_paths, repo_names, gitweb, bug_tracker=None, + tag_pattern=None, **kwargs): + kwargs.setdefault('title', None) super(GitSource, self).__init__(**kwargs) @@ -280,6 +288,7 @@ class GitSource(CachedSource): self.repo_names = repo_names.split() self.gitweb = gitweb + self.bug_tracker = bug_tracker self.tag_pattern = tag_pattern def _cache_key(self): @@ -338,7 +347,15 @@ class GitSource(CachedSource): ] proc = subprocess.Popen(git_log_args, stdout=PIPE) for line in proc.stdout: - hash, author, email, time, subject = line.strip().split('\x00') + hash, author, email, time, subject \ + = line.strip().decode('utf8').split('\x00') + + # Convert bug numbers in subject to URLs + if self.bug_tracker: + subject = helpers.literal( + re.sub(u'#(\d+)', self._linkify_bug_number, subject) + ) + commits.append( FrontPageGitCommit( hash = hash, @@ -359,3 +376,10 @@ class GitSource(CachedSource): updates.append(update) return updates + + def _linkify_bug_number(self, match): + """Regex replace function for changing bug numbers into links.""" + n = match.group(1) + bug_url = self.bug_tracker.format(match.group(1)) + return helpers.literal( + u"""{1}""".format(bug_url, match.group(0)))